Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added _rewrite_time_axis and refactoring of cmor module #92

Merged
merged 17 commits into from
Feb 16, 2023

Conversation

larsbuntemeyer
Copy link
Contributor

@larsbuntemeyer larsbuntemeyer commented Feb 13, 2023

This PR adds management of CF compliant time axis and bounds. Also did some refactoring to prepare for other cmor backend.

closes #79

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Merging #92 (2376f99) into master (781cc40) will decrease coverage by 1.17%.
The diff coverage is 69.11%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   78.30%   77.14%   -1.17%     
==========================================
  Files          21       22       +1     
  Lines        1037     1098      +61     
==========================================
+ Hits          812      847      +35     
- Misses        225      251      +26     
Flag Coverage Δ
unittests 77.14% <69.11%> (-1.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cordex/tutorial.py 63.49% <ø> (ø)
cordex/cmor/cmor.py 64.44% <61.45%> (-4.73%) ⬇️
cordex/cmor/config.py 75.00% <75.00%> (ø)
cordex/cmor/utils.py 91.17% <95.45%> (+1.40%) ⬆️
cordex/cmor/__init__.py 100.00% <100.00%> (ø)

@larsbuntemeyer larsbuntemeyer changed the title added _rewrite_time_axis added _rewrite_time_axis and refactoring of cmor module Feb 15, 2023
@larsbuntemeyer larsbuntemeyer changed the title added _rewrite_time_axis and refactoring of cmor module added _rewrite_time_axis and refactoring of cmor module Feb 15, 2023
@larsbuntemeyer larsbuntemeyer merged commit d444a09 into master Feb 16, 2023
@larsbuntemeyer larsbuntemeyer deleted the cmor_time branch February 16, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmor time and time_bnds
2 participants