This repository has been archived by the owner on Apr 27, 2022. It is now read-only.
truncate message as subject, update rubocop #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwd
reviewed
Feb 13, 2018
| @@ -12,7 +12,7 @@ def post(text:, type:, page:, ip:) | |||
| @page = page | |||
| @ip = ip | |||
|
|
|||
| mail(to: Rails.application.config.x.feedback_mail_to, subject: 'User feedback') | |||
| mail(to: Rails.application.config.x.feedback_mail_to, subject: text.truncate(100)) | |||
There was a problem hiding this comment.
Should we be sending the separator: ' ' option to #truncate to truncate on a word boundary?
There was a problem hiding this comment.
On an average feedback message and with 100 characters I don't see any big downsides to this and since it makes for slightly nicer output, sure.
houndci-bot
reviewed
Feb 13, 2018
| @@ -12,7 +12,7 @@ def post(text:, type:, page:, ip:) | |||
| @page = page | |||
| @ip = ip | |||
|
|
|||
| mail(to: Rails.application.config.x.feedback_mail_to, subject: 'User feedback') | |||
| mail(to: Rails.application.config.x.feedback_mail_to, subject: text.truncate(100, separator: ' ')) | |||
rwd
approved these changes
Feb 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.