Ea 3712 zoho sync addon #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(...) and an empty message aborts the commit.
nshweta90
reviewed
Jun 4, 2024
| private static final String ACCOUNTS = "Accounts"; | ||
|
|
||
|
|
||
| public String ZohoBulkCreateJob(String moduleAPIName) throws Exception { |
There was a problem hiding this comment.
Method can be divided into smaller parts
|
|
||
| } else if (actionResponse instanceof APIException) { | ||
| APIException exception = (APIException) actionResponse; | ||
| LOG.error("Status: " + exception.getStatus().getValue()); |
There was a problem hiding this comment.
Similar logging present in the else if block below which can be extracted in method
| private static final Logger LOG = Logger.getLogger(ZohoBatchDownload.class); | ||
| private static final String COMPLETED = "COMPLETED"; | ||
|
|
||
| public String downloadResult(Long jobId) throws Exception { |
There was a problem hiding this comment.
Method can be divided into smaller units to reduce the complexity and also multiple if blocks can be combined .
| return ""; | ||
| } | ||
|
|
||
| public static String unZipFile(String pathToZipFile) throws Exception { |
There was a problem hiding this comment.
Method can be divided into smaller units of each task and reduce the complexity
| return ""; | ||
| } | ||
| if (response.isExpected()) { | ||
| ResponseHandler responseHandler = response.getObject(); |
There was a problem hiding this comment.
Here as well we can have code extracted in smaller method to reduce complexity and to segregate tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers tickets https://europeana.atlassian.net/browse/EA-3711 & https://europeana.atlassian.net/browse/EA-3712