Debt/met 4997 dates normalization refactor part 3 #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utilize existent classes from java.
Prepare code for dates parsing alternatives
It is essentially the extractor
…rofound and applied during creation of the interval itself.
…nd central exception handling
jeortizquan
reviewed
Mar 9, 2023
There was a problem hiding this comment.
Overall I think we are good restructuring. I have some comments about the logger (check it in several places that this new form of logging was introduced), seems some leftover comments to be removed and about some suggestions about methods that can be renamed.
...zation/src/main/java/eu/europeana/normalization/dates/DateNormalizationExtractorMatchId.java
Outdated
Show resolved
Hide resolved
metis-normalization/src/main/java/eu/europeana/normalization/NormalizerImpl.java
Outdated
Show resolved
Hide resolved
metis-normalization/src/main/java/eu/europeana/normalization/dates/edtf/DateEdgeType.java
Outdated
Show resolved
Hide resolved
metis-normalization/src/main/java/eu/europeana/normalization/dates/edtf/InstantEdtfDate.java
Outdated
Show resolved
Hide resolved
metis-normalization/src/main/java/eu/europeana/normalization/dates/edtf/InstantEdtfDate.java
Outdated
Show resolved
Hide resolved
...t/java/eu/europeana/normalization/dates/extraction/dateextractors/EdtfDateExtractorTest.java
Outdated
Show resolved
Hide resolved
...u/europeana/normalization/dates/extraction/dateextractors/NumericPartsDateExtractorTest.java
Outdated
Show resolved
Hide resolved
...-normalization/src/test/java/eu/europeana/normalization/normalizers/DatesNormalizerTest.java
Show resolved
Hide resolved
...-normalization/src/test/java/eu/europeana/normalization/normalizers/DatesNormalizerTest.java
Outdated
Show resolved
Hide resolved
...n/java/eu/europeana/normalization/dates/extraction/dateextractors/AbstractDateExtractor.java
Outdated
Show resolved
Hide resolved
jeortizquan
reviewed
Mar 10, 2023
metis-normalization/src/main/java/eu/europeana/normalization/dates/edtf/Iso8601Parser.java
Show resolved
Hide resolved
...-normalization/src/test/java/eu/europeana/normalization/normalizers/DatesNormalizerTest.java
Show resolved
Hide resolved
...in/java/eu/europeana/normalization/dates/extraction/dateextractors/CenturyDateExtractor.java
Outdated
Show resolved
Hide resolved
...java/eu/europeana/normalization/dates/extraction/dateextractors/DcmiPeriodDateExtractor.java
Outdated
Show resolved
Hide resolved
.../main/java/eu/europeana/normalization/dates/extraction/dateextractors/EdtfDateExtractor.java
Outdated
Show resolved
Hide resolved
metis-normalization/src/main/java/eu/europeana/normalization/dates/edtf/InstantEdtfDate.java
Outdated
Show resolved
Hide resolved
jeortizquan
pushed a commit
that referenced
this pull request
Mar 27, 2023
* MET-4997: Prepare edtf date level 0 tests * MET-4997: Add Iso8601 specific parser Utilize existent classes from java. * MET-4997: Split iso extraction from dcmi. Prepare code for dates parsing alternatives * MET-4997: EdtfDatePartBuilder support * MET-4997: Introduce java time classes * MET-4997: Allow conditional month/day switching during creation of EdtfDatePart * MET-4997: After optimization, cleanup unecessary code * MET-4997: Remove integer fields from EdtfDatePart and cleanup * MET-4997: Remove isTimeOnly, it is irrelevant * MET-4997: Extract DateQualification for date building * MET-4997: Extract DateEdgeType for interval dates building * MET-4997: Remove duplicate date class * MET-4997: Split InstantEdtfDate and its builder * MET-4997: Add overwriting of date qualification * MET-4997: Comply to compareTo requirements * MET-4997: Merge EdtfParser in PatternEdtfDateExtractor. It is essentially the extractor * MET-4997: Reuse qualification and edges strings * MET-4997: Move allowSwitchMonthDay to withX method instead of build * MET-4997: Update parsing with temporalAccessors * MET-4997: Update DateLevel1Tests * MET-4997: Merge DateLevelXTest classes to PatternEdtfDateExtractorTest * MET-4997: Move prefix long year validation in builder * MET-4997: Rename PatternEdtfDateExtractor to EdtfDateExtractor * MET-4997: Use Month instead of YearMonth internally * MET-4997: Add deserialize string representation for DateEdgeType * MET-4997: Move date future de-validation in InstantEdtfDateBuilder * MET-4997: Introduce IntervalEdtfDateBuilder to make validation more profound and applied during creation of the interval itself. * MET-4997: Rename parameter * MET-4997: Introduce AbstractDateExtractor for default functionality and central exception handling * MET-4997: Introduce DateExtractionException for consistency * MET-4997: Handle the RuntimeExceptions * MET-4997: Remove redundant EdtfParseAndSerializeTest.java * MET-4997: Realign InstantEdtfDateNormalizerTest to DatesNormalizerTest * MET-4997: Separate result status from match identifier * MET-4997: Remove invalid match id, it is not relevant anymore * MET-4997: Strict validation for generics moved to dates building * MET-4997: Cleanup * MET-4997: Prepare tests for PatternBriefDateRangeDateExtractorTest * MET-4997: Cleanup PatternBriefDateRangeDateExtractor and renaming * MET-4997: Move year precision adjustments inside the instant date building * MET-4997: Restrict Date qualification rules on builder * MET-4997: Cleanup * MET-4997: Process review * MET-4997: Rename missed out method
stzanakis
deleted the
debt/MET-4997_Dates_normalization_refactor_part_3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.