Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/met 5756 implement new media processor subclass #652

Merged

Conversation

JoanaCMS
Copy link
Contributor

@JoanaCMS JoanaCMS commented Feb 1, 2024

No description provided.

Copy link
Contributor

@jeortizquan jeortizquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have a name suggestion for the processor and the metadata classes.

import eu.europeana.metis.mediaprocessing.model.ThreeDResourceMetadata;
import java.io.IOException;

class ThreeDProcessor implements MediaProcessor{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions Media3dProcessor or Object3dProcessor


import java.util.List;

public class ThreeDResourceMetadata extends AbstractResourceMetadata{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions Object3dResourceMetadata or Media3dResourceMetadata

@jeortizquan jeortizquan merged commit 3a28c33 into develop Feb 5, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants