-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/MET-5763 Add support for stl files in media processing #665
Merged
stzanakis
merged 10 commits into
develop
from
feat/MET-5763_Add_support_STL_files_media_processing
Mar 27, 2024
Merged
Feat/MET-5763 Add support for stl files in media processing #665
stzanakis
merged 10 commits into
develop
from
feat/MET-5763_Add_support_STL_files_media_processing
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeortizquan
requested changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion is to add some unit tests in MimeTypeDetectHttpClientTest
with the tests files to cover the 3 new cases.
…_processing # Conflicts: # metis-media-service/src/main/resources/org/apache/tika/mime/custom-mimetypes.xml # metis-media-service/src/test/java/eu/europeana/metis/mediaprocessing/http/MimeTypeDetectHttpClientTest.java
jochen-vermeulen
requested changes
Mar 21, 2024
...vice/src/test/java/eu/europeana/metis/mediaprocessing/extraction/MediaExtractorImplTest.java
Outdated
Show resolved
Hide resolved
jochen-vermeulen
pushed a commit
that referenced
this pull request
May 1, 2024
* MET-5763 Started implementing support for stl files * MET-5763 Updated custom mimetypes file * MET-5763 Added support for STL files * MET-5763 Fixed custom-mimetype file * MET-5763 Started writing unit tests * MET-5763 Fixed stl file detection * MET-5763 Fixed unit tests * MET-5763 Added javadoc * MET-5763 Code review comments, fixed unit tests
JoanaCMS
added a commit
that referenced
this pull request
Jun 18, 2024
* MET-5966: Align harvesting iterators and result objects. * MET-5966: Further deprecations marked and documented. * MET-5966: Http Harvest ID is relative file path. Account for deletion. * MET-5966: Fix unit tests. * MET-5966: Allow exceptions inside iterations. * MET-5966: Provide write option for output streams. * MET-5880 Fix user name not displaying when a user starts a workflow (#668) * MET-5880 Fix user name not displaying when a user starts a workflow * MET-5880 Upgrade maven-compiler-plugin Build fails because of sonar issue. Upgrading maven-compiler-plugin to perhaps solve the issue. * Feat/MET-5763 Add support for stl files in media processing (#665) * MET-5763 Started implementing support for stl files * MET-5763 Updated custom mimetypes file * MET-5763 Added support for STL files * MET-5763 Fixed custom-mimetype file * MET-5763 Started writing unit tests * MET-5763 Fixed stl file detection * MET-5763 Fixed unit tests * MET-5763 Added javadoc * MET-5763 Code review comments, fixed unit tests * MET-5875: catch correct exception for HttpGet and URL instantiations (#667) * MET-5875: normalize URI to avoid '//' in dereference client. * MET-5966: Simplify exception handling. * MET-5966: Add timestamp as a record property. --------- Co-authored-by: Simon Tzanakis <simon.tzanakis@europeana.eu> Co-authored-by: JoanaCMS <70145179+JoanaCMS@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.