feat: DS4CH layout with header and footer #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LeoniePeters
commented
Jan 2, 2024
•
LeoniePeters
commented
- Disables i18n for microsite/DS4CH.eu page
- Adds a ds4ch layout type
- Adds a DS4CHPageHeader component with navigation and sidebar navigation on mobile
- Adds a DS4CHPageFooter component
- Adds the Montserrat font
- Adds new stylesheets for the DS4CH brand
- Adds new components to the Europeana style guide under a separate DS4CH section
- Moves scrollToRouteHash from default layout into a mixin, also used by ds4ch layout
- Adds a file route.js under plugins/i18n which declares the routes that are not to be localised, including the DS4CH microsite page
|
JIRA ticket: EC-6599 |
|
Preview deployment: https://pr-2167.portal-js.dev.eanadev.org/ |
rwd
requested changes
Jan 8, 2024
packages/portal/src/lang/en.js
Outdated
| @@ -213,6 +213,15 @@ export default { | |||
| "left": "Left", | |||
| "right": "Right" | |||
| }, | |||
| "ds4ch": { | |||
| "dataSpaceForCulturalHeritage": "Data space for cultural heritage", | |||
| "ds4chHome": "Data space for cultural heritage home page", | |||
| > | ||
| <img | ||
| :src="logoSrc" | ||
| :alt="$t('ds4chHome')" |
There was a problem hiding this comment.
Updated to use ds4ch.logoAlt.
| // TODO: add i18n head when decided page should be multilingual | ||
|
|
||
| return { | ||
| title: APP_SITENAME, |
There was a problem hiding this comment.
There is already text for this in the English language file, so use it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.