Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: accessible attribution toggle #2182

Merged
merged 12 commits into from Feb 19, 2024

Conversation

LeoniePeters
Copy link
Contributor

No description provided.

@LeoniePeters LeoniePeters marked this pull request as ready for review February 12, 2024 08:19
Copy link

Preview deployment: https://pr-2182.portal-js.dev.eanadev.org/

});
}
},
handleFocusOutside(event) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to handleFocusin

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed to handleWindowFocusin and left a comment on what it's actually used for.

packages/portal/src/components/generic/CiteAttribution.vue Outdated Show resolved Hide resolved
packages/portal/src/components/generic/CiteAttribution.vue Outdated Show resolved Hide resolved
packages/portal/src/components/generic/CiteAttribution.vue Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Feb 19, 2024

@rwd rwd merged commit 013acbd into master Feb 19, 2024
17 checks passed
@rwd rwd deleted the refactor/accesible-4k-attribution-toggle branch February 19, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants