feat: client-only oEmbed on debug page #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rwd
commented
Apr 18, 2024
•
rwd
commented
- render oembed component client-only on oembed debug page
- facilitates debugging failed network requests via browser console
- set white background on oembed debug page content, to improve usability of form
- explicitly import client-side where used in vue files
- remove the client-side component mock
- support alert error being object, which it is in the case of oEmbed network errors
* facilitates debugging failed network requests via browser console * explicitly import client-side where used in vue files * remove the client-side component mock
|
JIRA ticket: EC-6733 |
|
Preview deployment: https://pr-2276.portal-js.dev.eanadev.org/ |
lbiedinger
approved these changes
Apr 18, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.