Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create Europeana APIs package #2325

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

rwd
Copy link
Contributor

@rwd rwd commented May 16, 2024

  • create a new apis package which contains the Europeana API client code formerly in plugins/europeana
  • keep those API client classes as minimal as possible, moving other helper functions out to either:
    • another new package, utils, for helper functions that may need to be used across packages; or
    • a new utils directory within the portal package for helper functions only it needs to use
  • load API config from env by default
  • decouple API config from nuxt context, delegating use of nuxt config in API config to europeana-apis plugin
  • change the signature of the EuropeanaEntityApi#get method to expect Entity API type and ID
  • move EuropeanaEntityApi#imageUrl to a new mixin, entityImageUrl
  • move EuropeanaRecordApi#mediaProxyUrl to EuropeanaMediaProxyApi#url
  • move Record API search method translation param handling into SearchInterface component
  • move Record API search result reduction to search util function reduceFieldsForSearchResult

Copy link

JIRA ticket: EC-6758

Copy link

Preview deployment: https://pr-2325.portal-js.dev.eanadev.org/

@rwd rwd added the styleguide Build and deploy a style guide preview label May 17, 2024
Copy link

Style guide deployment: https://pr-2325.styleguide.dev.eanadev.org/

Copy link

sonarcloud bot commented May 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
styleguide Build and deploy a style guide preview
Projects
None yet
1 participant