Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating TC queries #30

Merged
merged 21 commits into from Sep 2, 2020
Merged

Updating TC queries #30

merged 21 commits into from Sep 2, 2020

Conversation

Hobbesball
Copy link
Collaborator

With some balmy summer feedback from Collections Engagement colleagues, here's some more updates to our TC queries. Ideally these queries would be merged around end of August.

🏖☀🏖☀🏖☀🏖☀🏖☀🏖☀

@Hobbesball Hobbesball changed the base branch from master to dependabot/maven/solr_confs/collections_aliasing/asPlugin_Solr6/collections_aliasing/solr.version-8.4.1 August 13, 2020 12:30
@Hobbesball Hobbesball changed the base branch from dependabot/maven/solr_confs/collections_aliasing/asPlugin_Solr6/collections_aliasing/solr.version-8.4.1 to master August 13, 2020 12:30
@marrerom
Copy link
Contributor

marrerom commented Aug 18, 2020 via email

@marrerom marrerom merged commit 57b6027 into europeana:master Sep 2, 2020
@adamu
Copy link

adamu commented Nov 12, 2020

@Hobbesball Hello, here from your StackOverflow comment. The reason the rebase didn't work here is because this repo is squashing all the PRs. So what is happening is:

Your fork and PR:

  • Commit a
  • Commit b
  • Commit c

Upstream merges your PR:

  • Commit d (which contains all the changes from a, b, and c).

Then next time you make a PR, you carry on from your fork. But because upstream contains commit d, and none of your commits a, b, or c, the commits are effectively all resubmitted (even though they don't produce a diff, because d contained the same changes and you merged that into your branch).

You can fix it by resetting your master branch before starting a new PR, for example by doing something like git checkout -B master upstream/master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants