Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alias in MetaServiceProvider for injection #23

Closed
wants to merge 2 commits into from
Closed

Add alias in MetaServiceProvider for injection #23

wants to merge 2 commits into from

Conversation

alexjoffroy
Copy link
Contributor

Fix #19

Copy link
Owner

@eusonlito eusonlito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class name resolution via ::class is only available from PHP 5.5 and this package must support PHP 5.4 :)

Copy link
Owner

@eusonlito eusonlito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using PHPUnit PSR-0 namespace because used version 4.8 is comptabile with all tested PHP versions. Check https://travis-ci.org/eusonlito/laravel-Meta to tests review.

@alexjoffroy
Copy link
Contributor Author

Hi :)

Tests seems ok, even in 5.4, no ?
https://travis-ci.org/eusonlito/laravel-Meta/jobs/383735080

Anyway, when I submitted my PR, I have a fork from commit 51f0b44, tests were failing with my php 7.x:

PHP Fatal error:  Class 'PHPUnit_Framework_TestCase' not found in .../laravel-Meta/tests/Tests.php on line 4

Fatal error: Class 'PHPUnit_Framework_TestCase' not found in .../laravel-Meta/tests/Tests.php on line 4

Now, when I try from the current master, I don't have this one anymore :) So, I guess I can remove the commit.

Concerning "Class name resolution via Meta::class", is Eusonlito\LaravelMeta\Meta will be OK instead for 5.4 ?

Just as a sidenote, since 5.4 (and 5.5) are not supported anymore, is it still relevant to have support for them on this package ?

@eusonlito
Copy link
Owner

Done, Thanks!

@eusonlito eusonlito closed this Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency injection mixed with Facade usage
2 participants