Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit testing for every function and integrate with Travis CI #17

Closed
12 of 13 tasks
lewisgoddard opened this issue Oct 22, 2015 · 2 comments
Closed
12 of 13 tasks
Assignees

Comments

@lewisgoddard
Copy link
Member

Primary

  • New unit tests are added automatically.
  • Test against MySQL and MariaDB

Functions

  • function mysqli_array_build($connection, $sql)
  • function drop_table($connection, $settings, $table)
  • function mysqli_fetch_once($connection, $sql)
  • function peer_access($connection, $settings, $time, $peer)
  • function peer_completed($connection, $settings, $peer)
  • function peer_delete($connection, $settings, $peer)
  • function peer_new($connection, $settings, $time, $peer)
  • function maybe_binary_to_hex($binary)
  • function task($connection, $settings, $task, $value)
  • function tracker_allowed($connection, $settings)
  • function tracker_clean($connection, $settings, $time)

Impossible

As it stands, there are some functions whose composition is not lended to unit testing. These should probably be fixed later, and we can work around the super-globals for now.

  • optimize_table has no current failure states.
  • tracker_error contains an exit expression.
@lewisgoddard
Copy link
Member Author

Apparently we can't test against MariaDB and MySQL right now, so we'll stick the the older one and work from there.

@lewisgoddard
Copy link
Member Author

Optimize table has now become a task instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant