fix: change UART message buffer size to 35 bytes #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakubVanek
changed the title
|
The change compiles and the color sensor works with it on x86_64 laptop, hopefully nothing broke. |
JakubVanek
force-pushed
the
bugfix/msg-buffer-overflow
branch
from
8ab3064
to
a267c0a
Compare
dlech
reviewed
Aug 10, 2020
sensors/ev3_uart_sensor_ld.c
Outdated
| @@ -66,7 +66,8 @@ | |||
| #endif | |||
|
|
|||
| #define EV3_UART_MAX_DATA_SIZE 32 | |||
| #define EV3_UART_MAX_MESSAGE_SIZE (EV3_UART_MAX_DATA_SIZE + 2) | |||
| // extra bytes for: main command byte, INFO command byte, final checksum | |||
There was a problem hiding this comment.
Could you please change this to /* */ style comments (it is the Linux kernel style.
Previously, the buffer was only 34 bytes large. This would overflow the buffer if an INFO message with 32 byte payload was received. The problem is the INFO command byte that is not counted to the payload size.
JakubVanek
force-pushed
the
bugfix/msg-buffer-overflow
branch
from
a267c0a
to
4678583
Compare
|
Thanks! I have now changed the style of the comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the buffer was only 34 bytes large. This would overflow the buffer if an INFO message with 32 byte payload was received. The problem is the INFO command byte that is not counted to the payload size.
I haven't tested the change yet, but I will try to do so.