Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix #171

Merged
merged 4 commits into from
Dec 17, 2021
Merged

bugfix #171

merged 4 commits into from
Dec 17, 2021

Conversation

fanmingfei
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@fanmingfei
Copy link
Member Author

在 v1.2.2 之前,Spine 动画的 autoPlay 为 true,动画会循环播放 https://github.com/eva-engine/eva.js/pull/164/files#diff-46e9ae36c04e7a0abedc1e14fd9d1c4e81d8386e9bb851f85971ccdba8957804L131
在 v1.2.2 之前,Spine 动画在每加载完( armature 设置之前)调用播放是不生效的, 在 v1.2.2 #164 解决了这个问题
解决了不生效的问题以后,加载完成之前调用播放默认循环是false,导致autoPlay下本来循环动画不循环了,和之前表现不一致
为了解决这个问题,这里在未加载完之前调用播放默认循环,除非设置不循环参数

Copy link
Member

@terrykingcha terrykingcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

@lidongjies lidongjies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidongjies lidongjies merged commit 5d4b0da into dev Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants