Fix for issue #6 - warnings generated when attempting to render while self.bounds is CGRectZero. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2013 00:55
…are set to CGRectZero
…their origins do not match, but their sizes could both be CGSizeZero.
|
Let me know what you think, when you have time. |
ghost
mentioned this pull request
added 7 commits
October 3, 2013 11:10
…g from the set of subscribed views in -removeFromSuperview. Also added superview check in -subscribeViewWithBounds:
…superview and CGContexts ready to go at the beginning of -refresh. Per Apple's note in the documentation for NSParameterAssert, we do not assume that these are always disabled for all non-DEBUG builds.
…th -recreateImageBuffers.
…erview will be called when self.superview is assigned nil.
…'re initialized with -init (and it follows that -new works similarly).
|
@evadne has told me to "just merge it" and if there's anything wrong, she'll go to Singapore and kick my ass. Sounds like a plan. |
ghost
pushed a commit
that referenced
this pull request
Oct 5, 2013
Fix for issue #6 - warnings generated when attempting to render while self.bounds is CGRectZero.
ghost
merged commit
ghost
self-assigned this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to be smart about this by disabling rendering at the source, when the view is assigned a new frame or bounds, and being a bit more careful when this view moves to the superview.