Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert test to plain Test::More #2

Closed
daxim opened this issue Jul 4, 2013 · 5 comments
Closed

convert test to plain Test::More #2

daxim opened this issue Jul 4, 2013 · 5 comments

Comments

@daxim
Copy link

daxim commented Jul 4, 2013

The dep on Fennec pulls in a whole tail of other deps: http://deps.cpantesters.org/?module=Fennec&perl=any+version&os=any+OS

This makes it much more annoying or difficult to package perl5i > 2.10, and IMO not justified by Fennec benefit.

Please convert the H::SI test file to Test::More. It doesn't use any of the advanced Fennec features like parallelisation so it should be straight-forward, and grouping can also be achieved through subtest().

@exodist
Copy link
Collaborator

exodist commented Jul 4, 2013

I am confused by a couple things:

  1. Which deps are not already either core or deps of perl5i?
  2. Fennec is a build dependency, not a run dependency, so it should not be necessary to list it as a dep on the package and should not need to be packaged itself.

I am not going to flat out refuse this request, but I would like to talk about it more. Looking at the Fennec dependencies I see that it still pulls in Test::Exception::LessClever, I can update the mode that pulls that in to just use Test::Exception, etc. If we can solve the problem by reducing the Fennec dep's I would prefer to do it that way.

Currently I am trying fairly hard to promote Fennec. I would rather find solutions that make Fennec better and easier to use instead of solutions that simply remove Fennec.

@daxim
Copy link
Author

daxim commented Jul 4, 2013

The deps are ExtUtils::ParseXS (yes core module, but with a version that's only a year old, can it be decreased to 2.2210?), Fennec, Mock::Quick, Exporter::Declare, Parallel::Runner, Fennec::Lite, aliased, Meta::Builder, Test::Exception::LessClever.

Fennec is a build dependency […] and should not need to be packaged itself.

That's false.

@exodist
Copy link
Collaborator

exodist commented Jul 4, 2013

On Thu, Jul 4, 2013 at 7:44 AM, Lars Dɪᴇᴄᴋᴏᴡ 迪拉斯
notifications@github.comwrote:

The deps are ExtUtils::ParseXS (yes core module, but with a version that's
only a year old, can it be decreased to 2.2210?), Fennec, Mock::Quick,
Exporter::Declare, Parallel::Runner, Fennec::Lite, aliased, Meta::Builder,
Test::Exception::LessClever.

I will see what from these I can remove, off the top I can surely
remove aliased and Test::Exception::LessClever, ExtUtils::ParseXS is coming
from Test::Exception, I might be able to require an older min version.

Fennec is a build dependency […] and should not need to be packaged
itself.

That's false.

Interesting, my understanding of packaging must be incomplete. I would
expect that something not needed to run would not need to be installed. Or
did I accidentally list it as a running dependency?


Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-20480698
.

@exodist
Copy link
Collaborator

exodist commented Jul 4, 2013

Oh, interesting that you are calling out ExtUtils::ParseXS, the version
Fennec requires is older than the one Hash::StoredIterator requires, so
changing that would be fairly pointless, and yes the version
Hash::StoredIterator requires is the minimum, Schwern discovered that and
set it,

On Thu, Jul 4, 2013 at 8:06 AM, Chad Granum exodist7@gmail.com wrote:

On Thu, Jul 4, 2013 at 7:44 AM, Lars Dɪᴇᴄᴋᴏᴡ 迪拉斯 <notifications@github.com

wrote:

The deps are ExtUtils::ParseXS (yes core module, but with a version
that's only a year old, can it be decreased to 2.2210?), Fennec,
Mock::Quick, Exporter::Declare, Parallel::Runner, Fennec::Lite, aliased,
Meta::Builder, Test::Exception::LessClever.

I will see what from these I can remove, off the top I can surely
remove aliased and Test::Exception::LessClever, ExtUtils::ParseXS is coming
from Test::Exception, I might be able to require an older min version.

Fennec is a build dependency […] and should not need to be packaged
itself.

That's false.

Interesting, my understanding of packaging must be incomplete. I would
expect that something not needed to run would not need to be installed. Or
did I accidentally list it as a running dependency?


Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-20480698
.

@schwern
Copy link
Collaborator

schwern commented Aug 11, 2016

The tests were converted to Test2 which has a very small dep chain and all the benefits of Fennec.
b38e10f

@schwern schwern closed this as completed Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants