Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn a parsed parameter into an object. #30

Closed
schwern opened this issue Jul 5, 2011 · 2 comments
Closed

Turn a parsed parameter into an object. #30

schwern opened this issue Jul 5, 2011 · 2 comments
Labels
DO IT

Comments

@schwern
Copy link
Contributor

schwern commented Jul 5, 2011

Its painfully clear in the code that the parsed signature hash should be an object.

This issue is for step one, turn the parsed individual parameter (currently %sig) into an object. Don't worry about a public API, we can hash that out later, make something internally useful.

Use Mouse, we depend on it anyway might as well use it. It will drastically cut down the performance hit of an object.
This was referenced Feb 17, 2013
Open
Closed
@schwern
Copy link
Contributor Author

schwern commented Mar 25, 2013

I started work on this and recorded it as a live stream if someone wants to follow along.
http://www.twitch.tv/schwern/b/381982014

@schwern schwern mentioned this issue Mar 25, 2013
Merged
schwern added a commit that referenced this issue Apr 17, 2013
@schwern
Merge pull request #72 from schwern/issue/30
2a6d2ea 
Implement #30, the parsed parameter is now an object, Method::Signatures::Parameter.
@schwern
Copy link
Contributor Author

schwern commented Apr 17, 2013

All done.

@schwern schwern closed this as completed Apr 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DO IT
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schwern