Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a function that allows you to pass Options directly when you New the Datadog Exporter. #8

Conversation

marnie-eure
Copy link
Contributor

No description provided.

@evalphobia
Copy link
Owner

@marnie-eure Thank you for the PR!

Would you change that NewExporter use this new NewExporterWithOptions ?

(e.g. )

func NewExporter(name string) (*Exporter, error) {
	return NewExporterWithOptions(datadog.Options{
		Service: name,
	})
}

@marnie-eure
Copy link
Contributor Author

fixed 🐼

@evalphobia evalphobia merged commit 3d7a12c into evalphobia:master Feb 15, 2022
@evalphobia
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants