Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change it so it still passes lines with no ::INFO:: but show the file size as "Unknown" or similar #41

Closed
MrBruz opened this issue Oct 10, 2021 · 1 comment
Closed

Change it so it still passes lines with no ::INFO:: but show the file size as "Unknown" or similar #41

MrBruz opened this issue Oct 10, 2021 · 1 comment

Comments

@MrBruz
Copy link

MrBruz commented Oct 10, 2021

image
@a-camacho
Copy link

Same issue here

evan-buss added a commit that referenced this issue Oct 30, 2021
@evan-buss
Rewrite search parser to be more maintainable.
e0b1375 
- Don't mutate the line as we parse. It makes
  it difficult to reason about the current
  state.
- Split each piece into a separate function
  that takes the original line and extracts
  only what we are looking for
- Handle and add tests for special cases like
  when the file size isn't present. Fixes #41.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MrBruz @a-camacho