OpenBooks v4 #39
Merged
OpenBooks v4 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use map instead of slice to reduce complexity - Server sorting is now case insensitive. - Add tests for server sorting order.
- Use chi router and group all routes under basepath - Remove need for global variables - Update build script
- Treat anything in "Core" as independent of the project and create clear boundaries - Update Core APIs to reduce coupling and internal state - Rewrite DCC Downloader / Parser for better error handling and more idiomatic Go. - Create test implementations of IRC and DCC servers for use in testing / debugging changes. - Add more unit tests
- Add Title / Author text filters - Add format filtering - Make grid height fit the page size automatically
- Rewrite CLI to be cleaner and simpler
- Allow one off search and download commands
- Use contexts for cancellation
- Rewrite core irc reader and event dispatcher
- No longer using an interface for event
handling but a map of func handlers.
- This allows callers to specify only the
events they care about
- Callers are also responsible for logging instead of the core package
- Reader takes a context.Context instead of a custom channel solution
- Web Interface
- Various UI tweaks
- Convert server package to use contexts for both the main hub and
individual clients
- Convert server to use new "map-based" reader. Removed old
"interface-based" reader and its handlers
- Updated todo with future improvements.
- Improve messages - Add progress bar to CLI when downloading files - Remove dcc.ProgressFunc. Callers can implement their own progress tracking by monitoring calls to the io.Writer they pass in.
Refactoring: Feature improvements and bugfixes.
- Previously the ::HASH:: was included as part of the size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many updates across the board to both the web interface and the back-end structure.
Overview:
--persistflag is used, you can re-download previously downloaded books at any time.Closes #36
openbooks cli download '!book identifier string'andopenbooks cli search "my book"Closes #35
Closes #24
Closes #19