Add "Desktop Mode" as the default. #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- some webviews don't have native copy paste so I update the search field on user selection
- use filepath.join() instead of path.join() - change default download dir depending on which subcommand is selected - allow double clicking on windows (disable cobra mousetrap thing)
- allows double clicking the executable to open the GUI
- server code shouldn't care how the page is being displayed.
- replace AppThunk with createAsyncThunk
- This allows Calibre to watch a directory and only import the file when it's completed.
- Cross compilation becomes A LOT more complicated once CGO is in the mix. Requires the time and energy to get build scripts to work across all platforms, and update the automated Github Actions to build on multiple machines (MacOS requires MacOS runner, Windows / Linux require Linux runner) - This commit adds a build flag "webview" to enable webview desktop support but the default without the build flag is to open the browser on start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double clicking the executable will now start the server and open the browser.
Some users don't have experience using the terminal and this makes it easier to get started.
In the future this command may open a "webview" that appears to be a native desktop application without opening the browser. The code to do this is already included but not enabled by default due to complication in cross compiling CGO code.
To build a version for yourself with the webview instead of just opening the default browser: