Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model validation #11

Closed
wanprabu opened this issue Feb 4, 2013 · 4 comments
Closed

model validation #11

wanprabu opened this issue Feb 4, 2013 · 4 comments

Comments

@wanprabu
Copy link

wanprabu commented Feb 4, 2013

in your saveModel function, I think it's better to put
if(!$models[$i]->validate())
inside the next for.

Because when the condition goes to the first if (in case only one data posted)
if(!isset($data[0])))
then the model will not be validated

Thanks

@evan108108
Copy link
Owner

Sounds good and thanks for catching that. Would be great if you could submit a pull request with this change.

@evan108108
Copy link
Owner

Wanprabu have you had a chance to work on this?

@wanprabu
Copy link
Author

I will try it, but sorry I can't do it the near future. I'm quite busy this month. I hope next month I will have a chance to work on this.

@evan108108
Copy link
Owner

Cool. No problem. Thanks...

On Sunday, February 24, 2013, wahyu andy wrote:

I will try it, but sorry I can't do it the near future. I'm quite busy
this month. I hope next month I will have a chance to work on this.


Reply to this email directly or view it on GitHubhttps://github.com//issues/11#issuecomment-14023449.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants