New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor signin #61
Merged
Merged
Refactor signin #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shows "Reports" when on the reports page, and shows the contact UID when it is on the info page
…ahope into google-signin-new
- User login has been hooked up in place of firebase - Basic user search works - Basic event submission works - Contact info page works when user data is already loaded on navigation - Slideout nav works Things still broken - Show events on info page - Create contact - Google auth redirects ~3 times when you login, but I didn't care to figure out why - Some of the login logic is messy
1 task
Closed
evandana
pushed a commit
that referenced
this pull request
Dec 5, 2018
## Description - Deep linking to contact/intake (previously wasn't fetching data) ### Auth Fixes #66 ![image](https://user-images.githubusercontent.com/857676/47913084-29dfbe80-de71-11e8-9da4-3e7a3276308f.png) ![image](https://user-images.githubusercontent.com/857676/47912986-c6ee2780-de70-11e8-928b-3a757204853c.png) ![image](https://user-images.githubusercontent.com/857676/47913094-349a5380-de71-11e8-9b7f-7130aea4f15e.png)
pandathegiant
pushed a commit
to pandathegiant/keep-ahope
that referenced
this pull request
Jan 12, 2019
## Description - Deep linking to contact/intake (previously wasn't fetching data) ### Auth Fixes evandana#66 ![image](https://user-images.githubusercontent.com/857676/47913084-29dfbe80-de71-11e8-9da4-3e7a3276308f.png) ![image](https://user-images.githubusercontent.com/857676/47912986-c6ee2780-de70-11e8-928b-3a757204853c.png) ![image](https://user-images.githubusercontent.com/857676/47913094-349a5380-de71-11e8-9b7f-7130aea4f15e.png)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Auth
Fixes #66