-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test scaffolding and DO storage instrumentation tests #35
base: main
Are you sure you want to change the base?
Conversation
… one by accident.
…the node one by accident." This reverts commit 41d4ec4.
This reverts commit 5ef87786712a247dabffa470fa5bea8e1bd7571d.
It seems like the GitHub Actions pipeline isn't running since this is coming from a fork. I thought |
I have never used GitHub actions to be fair, but I do know that you really don't want to be automatically building/running code from forks, because people will just mine the latest shitty crypto coin from your account. But I have added you to the repository, so you should be able to test this for yourself now :) |
Workflows triggered by |
Hey @rtbenfield, I had to do some repository dark magic to remove a file that shouldn't have been in the repository. It would probably be easiest to redo this PR? |
Yeah no problem! I have the changes in my own branch so I can rebase and raise a new PR. |
Hey @rtbenfield, do I need to keep this PR around still? Would love to get this merged and get some tests in here :) |
This PR introduces Vitest with initial unit tests covering Durable Object storage instrumentation. These tests are focused on verifying the resulting spans match the expected behavior.
In writing these tests, I found that if Durable Object storage calls fail then the spans are not captured. The related tests are skipped until implementing a fix in a follow-up PR.