Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incompatibility with Pathlib #193

Closed
wants to merge 2 commits into from
Closed

Fix incompatibility with Pathlib #193

wants to merge 2 commits into from

Conversation

browniebroke
Copy link
Contributor

@browniebroke browniebroke commented Aug 13, 2018 •
edited

Fixes #192

  • Test cases to reproduce the problem(s)
  • Fix whitenoise code

laixintao
laixintao reviewed Aug 21, 2018
View reviewed changes
whitenoise/base.py
@@ -11,6 +12,8 @@
from .string_utils import (decode_if_byte_string, decode_path_info,
ensure_leading_trailing_slash)

TEXT_TYPE = str if sys.version_info[0] >= 3 else unicode

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you want move them to string_utils.py as BINARY_TYPE ?

whitenoise/whitenoise/string_utils.py

Line 4 in a51cc1a

if sys.version_info[0] >= 3:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion!

@browniebroke browniebroke mentioned this pull request Aug 30, 2018
Closed
2 tasks
@browniebroke
Copy link
Contributor Author

Closing in favour of #195

evansd added a commit that referenced this pull request Sep 11, 2018
@evansd
Cast paths to strings (they may be Pathlib instances)
6042b80 
Fixes #192 and replaces #193 and #195

Thanks @browniebroke for the original patches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laixintao laixintao laixintao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@browniebroke @laixintao