Add video file extensions to the default skip list#431
Merged
Conversation
adamchainz
approved these changes
Nov 2, 2022
adamchainz
left a comment
adamchainz
left a comment
Collaborator
There was a problem hiding this comment.
💯 Thank you for the PR
adamchainz
added a commit
that referenced
this pull request
Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whitenoise attempts to compress video files, which is a huge waste of time and disk space (given video files tend to be large and slow to compress, especially with brotli), as of course neither gzip nor brotli will manage to do any meaningful compression on an already-compressed video file. Also I think browsers will tend to do byte-range requests on video files, which of course cannot use the compressed versions. So I think the common video-file extensions should be added to the default
WHITENOISE_SKIP_COMPRESS_EXTENSIONS.