Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom AWS.SNS object in constructor #10

Merged
merged 3 commits into from
Aug 13, 2015

Conversation

SundeepK
Copy link
Contributor

Should resolve #9, let me know if there's anything I'm missing.

@evanshortiss
Copy link
Owner

No worries, this does almost all we need. I'll merge and a add a property check.

What I mean by checking properties is just something like so:

var obj = {
  // Assume these are all defined...
  getName: getName,
  name: 'Evan'
}

// Check does it have the properties we need
if (obj.hasOwnProperty('getName') && obj.hasOwnProperty('name')) {
  // Do something
}

@SundeepK
Copy link
Contributor Author

Wouldn't this require you to create a default SNS object and get the properties from that to compare whether the SNS object passed in has the same properties as the local version? Either way, I'll keep a lookout for your changes.

evanshortiss added a commit that referenced this pull request Aug 13, 2015
Allow custom AWS.SNS object in constructor
@evanshortiss evanshortiss merged commit 6ca5a13 into evanshortiss:master Aug 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow sns-mobile to take in a reference to an AWS SNS object
2 participants