Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print full name of nested types in error messages #166

Closed
saket opened this issue Nov 6, 2021 · 0 comments · Fixed by #204
Closed

Print full name of nested types in error messages #166

saket opened this issue Nov 6, 2021 · 0 comments · Fixed by #204
Labels
bug Something isn't working

Comments

@saket
Copy link
Contributor

saket commented Nov 6, 2021

When kotlin-inject is unable to find a provider for a type that's nested inside another type, it only prints its simple name. For example, Factory instead of SomeClass.Factory. This makes it slightly difficult to immediately recognize the type's name. Can the name of nested types prefixed with their parent class(es)?

- e: [ksp] Cannot find an @Inject constructor or provider for: Factory
+ e: [ksp] Cannot find an @Inject constructor or provider for: SomeClass.Factory
@evant evant added the bug Something isn't working label Nov 7, 2021
evant added a commit that referenced this issue May 30, 2022
@evant
Fix printing of AstClass to print full type including outer class
378d2a3 
This makes it easier to find what class error messages are referring too
as well as fixes an incorrect cache hit when 2 inner classes in the root
package share a name.

Fixes #166, #192
@evant evant mentioned this issue May 30, 2022
Merged
evant added a commit that referenced this issue May 30, 2022
@evant
Fix printing of AstClass to print full type including outer class
a24f0a0 
This makes it easier to find what class error messages are referring too
as well as fixes an incorrect cache hit when 2 inner classes in the root
package share a name.

Fixes #166, #192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix printing of AstClass to print full type including outer class evant/kotlin-inject
2 participants
@evant @saket