limit and offset params should always be coerced to numbers

evantahler · Apr 27, 2012 · ad48310 · ad48310
1 parent 8c9fbcb
commit ad48310
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/initializers/initActions.js b/initializers/initActions.js
@@ -51,8 +51,8 @@ var initActions = function(api, next)
 	});
 
 	api.processAction = function(api, connection, next){	
-		if(connection.params.limit == null){ connection.params.limit = api.configData.defaultLimit; }
-		if(connection.params.offset == null){ connection.params.offset = api.configData.defaultOffset; }
+		if(connection.params.limit == null){ connection.params.limit = api.configData.defaultLimit; }else{ connection.params.limit = parseFloat(connection.params.limit); }
+		if(connection.params.offset == null){ connection.params.offset = api.configData.defaultOffset; }else{ connection.params.offset = parseFloat(connection.params.offset); }
 		if(api.configData.logRequests){api.log("action @ " + connection.remoteIP + " | params: " + JSON.stringify(connection.params));}
 
 		if (connection.error === false){

diff --git a/initializers/initWebServer.js b/initializers/initWebServer.js
@@ -132,7 +132,6 @@ var initWebServer = function(api, next)
 		// requestorInformation
 		connection.response.requestorInformation = {};
 		connection.response.requestorInformation.remoteAddress = connection.remoteIP;
-		if(connection.requestCounter != null){ connection.response.requestorInformation.RequestsRemaining = api.configData.apiRequestLimitPerHour - connection.requestCounter; }
 		connection.response.requestorInformation.recievedParams = {};
 		for(var k in connection.params){
 			connection.response.requestorInformation.recievedParams[k] = connection.params[k] ;