New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"external" option doesn't work for scoped package #214

Closed

egoist opened this issue Jul 2, 2020 · 1 comment · Fixed by #216

egoist commented Jul 2, 2020

Repro:

// index.js
import '@xxx/xxx'

esbuild index.js --bundle --external:@xxx/xxx

It says:

index:1:7: error: Could not resolve "@xxx/xxx"
import '@xxx/xxx'
       ~~~~~~~~~~

esbuild v0.5.18

The text was updated successfully, but these errors were encountered:

Contributor

floydspace commented Jul 2, 2020 •

edited

The regression came with #186 in v0.5.14

floydspace pushed a commit to floydspace/esbuild that referenced this issue


          fix(externals): handle external scoped modules exclusion properly

3c36c7f

fix evanw#214

floydspace mentioned this issue

fix(externals): handle external scoped modules exclusion properly #216

Merged

evanw closed this as completed in #216

evanw pushed a commit that referenced this issue


          fix(externals): handle external scoped modules exclusion properly (#216)

8c9e867

fix #214

Co-authored-by: Victor Korzunin <victor.korzunin@blanco.services>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment