Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create nested directory if needed #164

Closed
wants to merge 1 commit into from
Closed

Create nested directory if needed #164

wants to merge 1 commit into from

Conversation

quasor
Copy link

@quasor quasor commented May 31, 2020

No description provided.

@evanw
Copy link
Owner

evanw commented Jun 3, 2020

There is already a call to os.MkdirAll above. Can you provide a description of the problem you're running into and a way to reproduce the problem?

@quasor
Copy link
Author

quasor commented Jun 4, 2020

Looks like the issue is the file suffix can contain a /
e.g. Wrote to out/preview_twitter.yDerV/Jy.svg (828 bytes)

@quasor quasor closed this Jun 4, 2020
evanw added a commit that referenced this pull request Jun 4, 2020
@evanw
fix #164: avoid slashes in file loader file names
a732214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quasor @evanw