Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest using Number.isNaN instead of isNaN in equals-nan warning #2471

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Suggest using Number.isNaN instead of isNaN in equals-nan warning #2471

merged 1 commit into from
Aug 15, 2022

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Aug 15, 2022 •
edited
Loading

Since the equals-nan warning is about equality comparison, it should suggest the stricter Number.isNaN instead of type coercing isNaN.

@kidonng kidonng changed the title Suggest using Number.isNaN instead of isNaN Suggest using Number.isNaN instead of isNaN in equals-nan warning Aug 15, 2022
@evanw evanw merged commit 5e085f5 into evanw:master Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kidonng @evanw