Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: css empty rulesets should be removed #851

Merged
merged 1 commit into from Feb 21, 2021
Merged

Fix: css empty rulesets should be removed #851

merged 1 commit into from Feb 21, 2021

Conversation

susiwen8
Copy link
Contributor

Close #850

if Rules ' length is 0, then skip it.

@evanw
Copy link
Owner

evanw commented Feb 20, 2021

A change like this should only happen when options.MangleSyntax is enabled (the --minify-syntax command-line flag).

@susiwen8
Copy link
Contributor Author

A change like this should only happen when options.MangleSyntax is enabled (the --minify-syntax command-line flag).

Understood, on it.

@susiwen8
Copy link
Contributor Author

@evanw Hi, MangleSyntax option has added.

@evanw
Copy link
Owner

evanw commented Feb 21, 2021

Could you also revert all of the unnecessary changes to the tests? I would do it myself but I think you have disabled push access from maintainers to your branch. At least I get "permission denied" when I try it.

@susiwen8
Copy link
Contributor Author

susiwen8 commented Feb 21, 2021 •
edited

Sure, I will revert it.

I think you have disabled push access from maintainers to your branch. At least I get "permission denied" when I try it.

Sorry about that, but I think I didn't disable it.

@susiwen8 susiwen8 closed this Feb 21, 2021
@susiwen8 susiwen8 reopened this Feb 21, 2021
@susiwen8
Copy link
Contributor Author

@evanw I have force-push to have clean commit. Please review it

evanw
evanw approved these changes Feb 21, 2021
View reviewed changes
Copy link
Owner

@evanw evanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evanw evanw merged commit ba901e0 into evanw:master Feb 21, 2021
@susiwen8 susiwen8 deleted the css-empty-rule branch February 21, 2021 10:04
@thlorenz thlorenz mentioned this pull request Aug 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanw evanw evanw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

css empty rule should be eliminate
2 participants
@susiwen8 @evanw