Bound stdout shifting to prevent excessive allocations #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this when using an incremental rebuild. In my project, the `stdout` can grow to 100mb+ during the initial build. During rebuild, the `stdout` is mostly empty. But the old code used an unbounded `slice`, which allocated almost the full 100mb.
|
Thank you. |
|
Good catch! I had intended to use |
1 task
1 task
evanw
added a commit
that referenced
this pull request
Mar 11, 2021
This was referenced Mar 12, 2021
This was referenced Mar 14, 2021
Closed
Closed
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when using an incremental rebuild. In my project, the
stdoutcan grow to 100mb+ during the initial build. During rebuild, thestdoutis mostly empty. But the old code used an unboundedslice, which allocated and shifted almost the full 100mb.