Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about -r when using with node #114

Merged
merged 2 commits into from
Oct 3, 2017

Conversation

mike-zorn
Copy link
Contributor

This resolves #113

@LinusU
Copy link
Collaborator

LinusU commented Sep 29, 2017

This looks very good, mind rebasing on top of master?

@mike-zorn
Copy link
Contributor Author

@LinusU I've rebased.

@uiteoi
Copy link
Contributor

uiteoi commented Oct 3, 2017

Option -r was added in Node v1.6.0

https://nodejs.org/api/cli.html#cli_r_require_module

@LinusU
Copy link
Collaborator

LinusU commented Oct 3, 2017

I think that everyone is using Node.js 4 or newer, can we skip mentioning versions of Node at all and just give them titles like "CLI Usage" and "Programmatic Usage"?

@uiteoi
Copy link
Contributor

uiteoi commented Oct 3, 2017

Skipping mentioning the version is fine, but if we mention a version might as well be the correct one.

@mike-zorn
Copy link
Contributor Author

mike-zorn commented Oct 3, 2017

Technically, the version is correct 😛 Although, this feature has been around since 1.6.0, it didn't work with things in node_modules until 2.2.0. See the second bullet point here. That being said, two years later, no one cares about versions 1-3, so I'll adjust the note.

@LinusU
Copy link
Collaborator

LinusU commented Oct 3, 2017

Thanks!

@LinusU LinusU merged commit 646092f into evanw:master Oct 3, 2017
@mike-zorn mike-zorn deleted the note-cli-option branch October 3, 2017 17:36
@LinusU
Copy link
Collaborator

LinusU commented Jan 16, 2018

Published in 0.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use -r when using in node
3 participants