Fix exception not printed when debugging

[mohd-akram]

This is based on my comment in PR #208 which caused exceptions not to be printed to the console when debugging (eg. using Chromium or VS Code). I've also simplified the code a bit.

[LinusU]

I think the problem with just setting process.exitCode is that it doesn't actually terminate the process, which I think is the expected outcome.

Would it be possible to keep the current behavior if fs is available?

[mohd-akram]

fs is always available, we need to check if we're running in debug/inspect mode. I've found one way to do this using the inspector module, but right now browserify returns an error when using it, pending browserify/browserify#1854. In the meantime, I've updated the PR to use process.exit().

[LinusU]

Unfortunately calling process.exit right after calls to console.error won't make sure that the output is flushed, and will more often than not result in cut off text. That's why it used fs.writeSync before.

[mohd-akram]

Is it really more often than not though? I think this problem only happens when you're printing large amounts of text (see nodejs/node#6456). Also, the switch from console.error to fs.writeSync seems to have happened only a few months ago and both the issue and PR for it did not give a way to actually cause the bug as far as I can tell.

A possible workaround mentioned in the node issue I linked is to add process.stderr._handle.setBlocking(true); before printing and exiting.

[LinusU]

process.stderr._handle.setBlocking(true); sounds good, can you add it? 👍

[mohd-akram]

I've updated the PR.

[LinusU]

Is there a specific reason for changing this? It will change the before behavior of not exposing us in process.listeners('uncaughtException'). I'm not saying that one way or the other is better, but we could potentially break something that depended on it not showing up...

[mohd-akram]

Taking over process.emit seemed like overkill IMO and a non-standard way of doing it. Not directly related to this PR, however.

[mohd-akram]

I've simplified the PR to just the necessary changes.

[LinusU]

Thank you!

[LinusU]

Published as v0.5.7 🚢