Fix RangeError on large files #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the source file and/or the source map URL is sufficiently large (think several MB) the regexp search to find the URL can run into this issue: https://code.google.com/p/v8/issues/detail?id=3878 Change the regexp to look just for the prefix and extract the URL using substring, which scales better. This now doesn't pay attention to single and double quotes anymore, reading the spec there seems to be no need for it.
|
Any update on this? It fixes our maximum call stack issues and would be nice to have merged. |
|
@glortho yup, very little movement here. But I just noticed that there is #87, are you still running into the RangeError with that? #87 (comment) sounds like it also fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the source file and/or the source map URL is sufficiently large (think several MB) the regexp search to find the URL can run into this issue: https://code.google.com/p/v8/issues/detail?id=3878
Change the regexp to look just for the prefix and extract the URL using substring, which scales better.
This now doesn't pay attention to single and double quotes anymore, reading the spec there seems to be no need for it. Do you know of quoted source map URLs in the wild?
FWIW we've run into the RangeError with a large webpack development bundle on Chrome Version 43.0.2357.130 (64-bit).