New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextField.js - componentWillReceiveProps - Changing this.props.text t… #32

Open

giladartzi wants to merge 1 commit into evblurbs:master from giladartzi:master

giladartzi commented Oct 6, 2016

…o this.state.text

The scenario is like so:

TextField is focused, but does not have a value.
props are changing
componentWillReceiveProps is triggered, and it's comparing this.props.text to this.props.value.
this.props.text is undefined and does not equal this.props.value which is an empty string
sinkLabel function is called, but TextField is still focused. (This is the issue)

In my opinion, text value should be read from the state and not the props.

Please let me know what you think :-)


          TextField.js - componentWillReceiveProps - Changing this.props.text t…

a88d427

…o this.state.text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment