Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tariff templates #562

Merged
merged 5 commits into from
May 8, 2024
Merged

Add tariff templates #562

merged 5 commits into from
May 8, 2024

Conversation

naltatis
Copy link
Member

@naltatis naltatis commented May 4, 2024

Fixes #558, #550

Depends on evcc-io/evcc#13756 (docs templates copied manually once for testing)

  • introduced a separate tariff page
  • content is based on core templates (similar to chargers, vehicles, ...)
  • added forecast plugin example

Screenshots of English and German version:

german


english

\cc @VolkerK62

@VolkerK62
Copy link
Contributor

Wow, krass, was da alles dazugekommen ist :)
Aber fehlt nicht noch custom bei festem Preis https://docs.evcc.io/docs/reference/configuration/tariffs#type-custom

@andig
Copy link
Member

andig commented May 5, 2024

@naltatis ich fand die Landesindikation im Namen ganz gut, z.B. Pun (IT). Ist das mit Absicht rausgeflogen?

@naltatis
Copy link
Member Author

naltatis commented May 5, 2024

ich fand die Landesindikation im Namen ganz gut, z.B. Pun (IT). Ist das mit Absicht rausgeflogen?

@andig Ja, siehe evcc-io/evcc#13756 (comment)

@andig
Copy link
Member

andig commented May 8, 2024

@naltatis Preis in €- vmtl. sind die Templates noch falsch.

@naltatis
Copy link
Member Author

naltatis commented May 8, 2024

Aber fehlt nicht noch custom bei festem Preis

@VolkerK62 Danke für den Hinweis. Ist ergänzt.

@naltatis naltatis merged commit c1965af into main May 8, 2024
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the tariff_templates branch May 8, 2024 12:11
@naltatis naltatis mentioned this pull request May 8, 2024
@mdkeil
Copy link
Contributor

mdkeil commented May 10, 2024

Was mir aufgefallen ist, das z.B. die description von bzn (Stromanbieter Frauenhofer ISE ) nicht in die Doku übernommen worden ist.. So ist es natürlich für den Nutzer wenig hilfreich..

https://github.com/evcc-io/evcc/blob/2254fedde18b13ac5405eb2d32270c4b2944c76c/templates/definition/tariff/energy-charts-api.yaml#L10C3-L35C94

@naltatis
Copy link
Member Author

Ah, das ist auch in der Tat nicht korrekt. Das muss help statt description heißen.

@andig
Copy link
Member

andig commented May 10, 2024

Closed in evcc-io/evcc@c8b3e24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document: Tariff: add forecast provider
4 participants