Close modbus connection if operation fails to reestablish connection (#…

…221)
evcc-io · Jul 18, 2020 · 173667a · 173667a
1 parent a94f822
commit 173667a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/meter/modbus.go b/meter/modbus.go
@@ -105,7 +105,9 @@ func (m *Modbus) floatGetter(op modbus.Operation) (float64, error) {
 		}
 	}
 
-	if err == nil {
+	if err != nil {
+		m.conn.Close() // close connection in case of modbus error
+	} else {
 		m.log.TRACE.Printf("%+v", res)
 	}
 

diff --git a/provider/modbus.go b/provider/modbus.go
@@ -124,6 +124,7 @@ func (m *Modbus) FloatGetter() (float64, error) {
 		}
 
 		if err != nil {
+			m.conn.Close() // close connection in case of modbus error
 			return 0, errors.Wrap(err, "read failed")
 		}
 
@@ -144,7 +145,9 @@ func (m *Modbus) FloatGetter() (float64, error) {
 		}
 	}
 
-	if err == nil {
+	if err != nil {
+		m.conn.Close() // close connection in case of modbus error
+	} else {
 		m.log.TRACE.Printf("%+v", res)
 	}