Fix SMA reporting negativ 0 value (#126)

evcc-io · May 12, 2020 · a44f424 · a44f424
1 parent bb0a7e6
commit a44f424
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/meter/sma.go b/meter/sma.go
@@ -109,7 +109,10 @@ func (sm *SMA) receive() {
 				sm.updated = time.Now()
 			}
 		} else if power, ok := msg.Values[sma.ExportPower]; ok {
-			sm.power = -power
+			sm.power = 0
+			if power > 0 {
+				sm.power = -power
+			}
 			sm.updated = time.Now()
 		} else if power, ok := msg.Values[sma.ImportPower]; ok {
 			sm.power = power

diff --git a/meter/sma/listener.go b/meter/sma/listener.go
@@ -157,6 +157,8 @@ func (l *Listener) processMessage(src *net.UDPAddr, b []byte) (Telegram, error)
 		Values: obisValues,
 	}
 
+	//	l.log.TRACE.Printf("recv %v", msg.Values)
+
 	return msg, nil
 }
 

diff --git a/meter/sma/listener_test.go b/meter/sma/listener_test.go
@@ -4,6 +4,8 @@ import (
 	"net"
 	"reflect"
 	"testing"
+
+	"github.com/andig/evcc/util"
 )
 
 func TestListenerProcessMessage(t *testing.T) {
@@ -186,7 +188,9 @@ func TestListenerProcessMessage(t *testing.T) {
 	}
 	for _, tc := range tests {
 		t.Run(tc.name, func(t *testing.T) {
-			l := &Listener{}
+			l := &Listener{
+				log: util.NewLogger("sma "),
+			}
 
 			buffer := tc.response
 			read := len(buffer)