Skip to content

Commit

Permalink
Revert "Mercedes: add odometer"
Browse files Browse the repository at this point in the history
This reverts commit 31201a9.
  • Loading branch information
andig committed Apr 9, 2023
1 parent 274a87d commit ebff68a
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 39 deletions.
19 changes: 1 addition & 18 deletions vehicle/mercedes/api.go
Expand Up @@ -68,19 +68,6 @@ func (v *API) Range(vin string) (EVResponse, error) {
return res, err
}

// Odometer implements the /odo response
func (v *API) Odometer(vin string) (EVResponse, error) {
var res EVResponse

uri := fmt.Sprintf("%s/vehicles/%s/resources/odo", v.BaseURI(), vin)
err := v.GetJSON(uri, &res)
if err != nil {
res, err = v.allinOne(vin)
}

return res, err
}

// allinOne is a 'fallback' to gather both metrics range and soc.
// It is used in case for any reason the single endpoints return an error - which happend in the past.
func (v *API) allinOne(vin string) (EVResponse, error) {
Expand All @@ -89,7 +76,7 @@ func (v *API) allinOne(vin string) (EVResponse, error) {
uri := fmt.Sprintf("%s/vehicles/%s/containers/electricvehicle", v.BaseURI(), vin)
err := v.GetJSON(uri, &res)

var evres EVResponse
evres := EVResponse{}

for _, r := range res {
if r.Soc.Timestamp != 0 {
Expand All @@ -100,10 +87,6 @@ func (v *API) allinOne(vin string) (EVResponse, error) {
if r.RangeElectric.Timestamp != 0 {
evres.RangeElectric = r.RangeElectric
}

if r.Odometer.Timestamp != 0 {
evres.Odometer = r.Odometer
}
}

return evres, err
Expand Down
3 changes: 1 addition & 2 deletions vehicle/mercedes/identity.go
Expand Up @@ -50,8 +50,7 @@ func NewIdentity(log *util.Logger, id, secret string, options ...IdentityOption)
Scopes: []string{
oidc.ScopeOpenID,
oidc.ScopeOfflineAccess,
"mb:vehicle:mbdata:evstatus", // soc, range
"mb:vehicle:mbdata:payasyoudrive", // odo
"mb:vehicle:mbdata:evstatus",
},
}

Expand Down
16 changes: 1 addition & 15 deletions vehicle/mercedes/provider.go
Expand Up @@ -10,7 +10,6 @@ import (
type Provider struct {
chargerG func() (EVResponse, error)
rangeG func() (EVResponse, error)
odoG func() (EVResponse, error)
}

// NewProvider creates a vehicle api provider
Expand All @@ -22,9 +21,6 @@ func NewProvider(api *API, vin string, cache time.Duration) *Provider {
rangeG: provider.Cached(func() (EVResponse, error) {
return api.Range(vin)
}, cache),
odoG: provider.Cached(func() (EVResponse, error) {
return api.Odometer(vin)
}, cache),
}
return impl
}
Expand All @@ -40,21 +36,11 @@ func (v *Provider) Soc() (float64, error) {
}

// Range implements the api.VehicleRange interface
func (v *Provider) Range() (int64, error) {
func (v *Provider) Range() (rng int64, err error) {
res, err := v.rangeG()
if err == nil {
return int64(res.RangeElectric.Value), nil
}

return 0, err
}

// Odometer implements the api.VehicleOdometer interface
func (v *Provider) Odometer() (int64, error) {
res, err := v.odoG()
if err == nil {
return int64(res.Odometer.Value), nil
}

return 0, err
}
4 changes: 0 additions & 4 deletions vehicle/mercedes/types.go
Expand Up @@ -9,8 +9,4 @@ type EVResponse struct {
Value int64 `json:",string"`
Timestamp int64
}
Odometer struct {
Value int64 `json:",string"`
Timestamp int64
} `json:"odo"`
}

0 comments on commit ebff68a

Please sign in to comment.