Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit pv current in case of imminent phase switch #13254

Closed
wants to merge 10 commits into from
Closed

Limit pv current in case of imminent phase switch #13254

wants to merge 10 commits into from

Conversation

MarkusGH
Copy link
Contributor

@MarkusGH MarkusGH commented Apr 1, 2024

Title says it all.
Fix #13182

@MarkusGH
Update loadpoint.go
db3e05b 
Limit pv current in case of imminent phase switch
@MarkusGH
Update loadpoint_phases_test.go
8ed4f0d 
Fix text
@MarkusGH
Update loadpoint_phases_test.go
170ebdc 
Fix formatting
@MarkusGH
Update loadpoint.go
3116208 
Fix return value
@MarkusGH
Update loadpoint.go
92d5273 
Fox return value
@MarkusGH
Update loadpoint_phases_test.go
c396a6d 
Fix test for pvScalePhases
@MarkusGH MarkusGH marked this pull request as ready for review April 1, 2024 16:59
@andig andig added the enhancement New feature or request label Apr 1, 2024
@andig andig requested a review from GrimmiMeloni April 1, 2024 17:08
GrimmiMeloni
GrimmiMeloni approved these changes Apr 2, 2024
View reviewed changes
Copy link
Sponsor Collaborator

@GrimmiMeloni GrimmiMeloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the magic value, but would also be OK to keep as is.
I like the way this change "stays in the neighborhood". Good stuff.

core/loadpoint.go Outdated Show resolved Hide resolved
GrimmiMeloni
GrimmiMeloni approved these changes Apr 3, 2024
View reviewed changes
Copy link
Sponsor Collaborator

@GrimmiMeloni GrimmiMeloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkusGH
Update loadpoint.go
24fa1c7 
Added check for maxCurrent
@andig andig closed this Apr 4, 2024
@evcc-io evcc-io locked as too heated and limited conversation to collaborators Apr 4, 2024
@MarkusGH MarkusGH deleted the patch-4 branch April 4, 2024 18:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andig andig andig left review comments

@premultiply premultiply premultiply left review comments

@GrimmiMeloni GrimmiMeloni GrimmiMeloni approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MarkusGH @andig @premultiply @GrimmiMeloni