Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http: don't send body on GET requests #14317

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Http: don't send body on GET requests #14317

merged 1 commit into from
Jun 12, 2024

Conversation

andig
Copy link
Member

@andig andig commented Jun 12, 2024

Fix #14192

@panzerdev could you give it a try?

@andig andig added the bug Something isn't working label Jun 12, 2024
@panzerdev
Copy link
Sponsor Contributor

[http  ] TRACE 2024/06/12 20:16:20 GET http://192.168.2.236/rpc/Switch.Set?id=0&on=false
[http  ] TRACE 2024/06/12 20:16:20 {"was_on":true}

[http  ] TRACE 2024/06/12 20:16:17 GET http://192.168.2.236/rpc/Switch.Set?id=0&on=true
[http  ] TRACE 2024/06/12 20:16:17 {"was_on":false}

Bug fixed, sorry I couldn't contribute this myself... children just bring home all kind of illnesses

@andig
Copy link
Member Author

andig commented Jun 12, 2024

Thanks for confirming 👍🏻

@andig andig merged commit 3735c8c into master Jun 12, 2024
6 checks passed
@andig andig deleted the fix/http-provider branch June 12, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP Plugin sets body on GET request
2 participants