-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DaheimLaden charger #1699
Add DaheimLaden charger #1699
Conversation
Thanks for the review @andig |
fa78226
to
1fe6068
Compare
525a995
to
6f3f0f7
Compare
Signed-off-by: Utsav Anand <utsavanand2@gmail.com>
1fe6068
to
fee7c08
Compare
charger/daheimladen.go
Outdated
} | ||
|
||
if changeConfigRes.Status != "Accepted" { | ||
return fmt.Errorf("charging station refused to change max current") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping
/rebase |
0f24342
to
9956189
Compare
LGTM apart from the strange timeout setting- that needs be fixed |
efe39da
to
f195da5
Compare
c3412a5
to
c9af273
Compare
Hi @andig :) |
84fdeab
to
fd074b0
Compare
Once everything seems good to you, before we do the final merge to master, I'll make sure that I change the |
fd074b0
to
59e574a
Compare
As a request from andig, I apply here for an implementation of my wallbox. I apologize if I posted in the wrong place - if that is the case, please help me out. Thank you in advance. Current state of my progress:
What comes up next? |
If you have a working config you can try this binary and add your charger to the config. |
Hi @scrub11 :) I'm Utsav from Daheimladen. |
@andig @utsavanand2 |
I am on it today and I have two questions:
Thank you in advance. |
Hi @scrub11 ! |
Hi @utsavanand2: |
PS: As I have the time to look at this today, I would take the liberty to help out @andig with this question. Please feel free to correct me if I'm wrong @andig ;) @scrub11 The compressed file ending with .gz that Andreas provided you with when uncompressed will give a binary file that is the executable you will be running on the raspberry pi. Probably the next thing to do here would be to add the configuration to the PV system you own. You can check the list of the meters supported here and add them to the evcc.dist.yaml . sudo chmod +x /path/to/evcc The last thing to do would be to try and run the evcc binary with the yaml configuration you edited. /path/to/evcc -c /path/to/evcc.dist.yaml
|
@utsavanand2: Thank you very much, thanks to your advice I got it up and running so far! :) |
@scrub11 I undestand the DaheimLaden integration is working and we can merge it now? |
I don't know if I really understand what you mean. I used your zipped binary and put it on my Raspi. As you know from the other discussion, I still encounter some unsolved issues. Due to that I cannot tell you if the complete integration is working... EVCC seems to work, or, to be more precise, it's diagnostic tool seems to work. |
Good afternoon, I have a working config for a phoenix contact wallbox and the E3DC PV / Battery / Grid. The daheimladen V1 is not yet integrated, but should join latest when our BEV will arrive. Best Regards and thank you for the great work. Sebastian Dietz |
Binary kommt morgen… Welches OS? |
Ubuntu server. Der Api key fehlt allerdings noch von daheimladen..... |
3090613
to
dd8c4cf
Compare
Signed-off-by: Utsav Anand <utsavanand2@gmail.com>
Hi @andig ! I just realised that when I run these commands: git clone https://github.com/evcc-io/evcc.git
git checkout feature/daheimladen Then it doesn't contain the latest changes that we made. But it does show up in the |
Strange. What does git log say? |
9fcfb1f
to
79d6388
Compare
@andig This is what I see, seems to be in line with what Github is saying in the commit history at the top |
Looks as expected. What exactly are you missing? |
Just checked the code- PR looks as I would expect? |
@andig Yes the PR looks just fine. I believe we can merge it now based on the user test results?
git clone https://github.com/evcc-io/evcc.git
git checkout feature/daheimladen I was able to see my previously made changes like seeing the timeout set to 0, but in the later commits I had them removed. But I guess its not showing up probably because of some user permissions, the previous ones were showing up because of your rebase (which was your commit), this might be the reason why I couldn't see those changes in |
Signed-off-by: Utsav Anand <utsavanand2@gmail.com> Co-authored-by: andig <cpuidle@gmx.de>
Integration with DaheimLaden charging stations with it's REST API
Description
This PR implements the methods on the skeleton recommended by @andig.
Any recommendations for improvement and making the code more readable are welcome :)