Update for EM2GO chargers #7099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 28, 2023 18:44
premultiply
reviewed
Mar 28, 2023
|
@dniakamal hat die Box immer einen integrierten Zähler? Falls nein müssten wir die Funktionalität noch "dekorieren"- kann ich gerne mach wenn ich weiß, wie wir das herausfinden? Bzgl. Modbus wäre es schöner zu schreiben, welche Version notwendig ist? |
andig
pushed a commit
that referenced
this pull request
Mar 30, 2023
* Changed brand 'D-Parts' to 'EM2GO', Updated template docs and definition for em2go, Updated em2go.go: completed ModBus registers, added Status F, Voltages, Powers, extended diagnosis. * Fix test * Fix test * Removed PhasePowers as it´s not being unused by chargers * Fix build, fix CurrentPower --------- Co-authored-by: Dominik Niakamal <dominik.niakamal@d-parts.de>
Danke für den Push! Ja die Boxen haben alle integrierte Zähler (manche davon MID-Zähler, hier unterscheiden wir beim Output aber nicht). ModBus TCP wird ab Version 1.01 (Pro Power) bzw. 3.15 (OCPP/ONC Modelle) unterstützt. |
andig
pushed a commit
that referenced
this pull request
Apr 2, 2023
* Changed brand 'D-Parts' to 'EM2GO', Updated template docs and definition for em2go, Updated em2go.go: completed ModBus registers, added Status F, Voltages, Powers, extended diagnosis. * Fix test * Fix test * Removed PhasePowers as it´s not being unused by chargers * Fix build, fix CurrentPower --------- Co-authored-by: Dominik Niakamal <dominik.niakamal@d-parts.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues work on EM2GO chargers as started with PR #3094