Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix measuredPhases out of sync due to delayed phase switching by charger #7162

Merged
merged 5 commits into from Apr 2, 2023

Conversation

MarkusGH
Copy link
Contributor

@MarkusGH MarkusGH commented Apr 2, 2023

Fix #7166

Fix measuredPhases out of sync due to delayed phase switching by charger
Prevent phase warning due to delayed phase switching by charger
@MarkusGH MarkusGH marked this pull request as draft April 2, 2023 09:27
Fix compile error
Refactor measuredPhases fix and correct compile errors
Refactor measuredPhases fix and correct compile errors
if lp.guardGracePeriodElapsed() {
lp.log.WARN.Printf("ignoring inconsistent phases: %dp < %dp observed active", phases, measuredPhases)
}
lp.resetMeasuredPhases()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich gehe bei allem mit- nur warum sollten wir das tun? Wir messen doch bei jedem Durchlauf, die Werte sind also aktuell!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich gehe bei allem mit- nur warum sollten wir das tun? Wir messen doch bei jedem Durchlauf, die Werte sind also aktuell!

Sind sie leider nicht - es wird nur während der Ladung gemessen. Das Problem tritt ja genau dann auf wenn das Laden geendet hat.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dann müsste da aber eigentlich ja auch sofort 0 rauskommen.
Warum tut es das nicht?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das tut es nicht weil die alte Messung vor dem Umschaltung noch vorhanden ist. Umschaltung ist träge und kann zurück kommen, bevor umgeschaltet wurde. Dann bleibt auch der alte Messwert stehen.

Mit dieser Erklärung passt das für mich. Was meinst Du?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja, ok, jetzt verstehe ich es auch.
Solange dann nicht nochmal ein neuer "alter" Realmesswert kommt...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dann würde ja im Fehlerfall wieder resettet.

@andig andig marked this pull request as ready for review April 2, 2023 12:46
@andig andig merged commit 8ae426e into evcc-io:master Apr 2, 2023
5 checks passed
@andig
Copy link
Member

andig commented Apr 2, 2023

Nightly in 20min

@MarkusGH MarkusGH deleted the patch-2 branch April 2, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Measured phases "stuck" when charging stops, leading to error messages
3 participants