Pseudo charger/feature sync #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andig
reviewed
Apr 28, 2021
internal/charger/fritzdect.go
Outdated
| // fetch basicdevicestats | ||
| resp, err := c.execFritzDectCmd("getbasicdevicestats") | ||
| if err != nil { | ||
| return math.NaN(), err |
There was a problem hiding this comment.
ich geb immer 0 zurück. err zeigt an dass der Wert nicht gilt
internal/charger/fritzdect.go
Outdated
|
|
||
| // unmarshal devicestats | ||
| var statsresp fritzdect.Devicestats | ||
| err = xml.Unmarshal([]byte(resp), &statsresp) |
internal/charger/fritzdect.go
Outdated
| } | ||
|
|
||
| // select energy value of current day | ||
| energylst := strings.Split(statsresp.Energy.Values[1], ",") |
internal/charger/fritzdect.go
Outdated
| // select energy value of current day | ||
| energylst := strings.Split(statsresp.Energy.Values[1], ",") | ||
| var energy float64 | ||
| energy, err = strconv.ParseFloat(energylst[0], 64) |
internal/charger/fritzdect/types.go
Outdated
|
|
||
| import "encoding/xml" | ||
|
|
||
| // getdevicestats command response (AHA-HTTP-Interface) |
| Energy Energy `xml:"energy"` | ||
| } | ||
|
|
||
| type Energy struct { |
There was a problem hiding this comment.
internal/charger/tasmota.go
Outdated
|
|
||
| // ChargedEnergy implements the api.ChargeRater interface | ||
| func (c *Tasmota) ChargedEnergy() (float64, error) { | ||
| var tStatusSNS tasmota.StatusSNSResponse |
There was a problem hiding this comment.
resp -> die heissen überall sonst auch so ;)
internal/charger/tasmota.go
Outdated
|
|
||
| // Execute Tasmota Status 8 command | ||
| err := c.GetJSON(c.cmdUri("Status 8"), &tStatusSNS) | ||
| if err != nil { |
There was a problem hiding this comment.
weg- einfach unten err zurück geben
added 2 commits
April 28, 2021 22:44
andig
reviewed
Apr 29, 2021
internal/charger/tasmota.go
Outdated
|
|
||
| return int(1) == tStatus.Status.Power, err | ||
| return int(1) == resp.Status.Power, err |
There was a problem hiding this comment.
warum nicht einfach resp.Status.Power == 1 ?
There was a problem hiding this comment.
ist wohl ein "Artefact" aus der Entwicklungsphase ...
andig
reviewed
Apr 29, 2021
internal/charger/tasmota.go
Outdated
| func (c *Tasmota) ChargedEnergy() (float64, error) { | ||
| var resp tasmota.StatusSNSResponse | ||
|
|
||
| // Execute Tasmota Status 8 command |
There was a problem hiding this comment.
Inline Kommentare immer klein. Trägt der kommentar wirklich was zum Erkenntnisgewinn bei?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dieser PR führt auch für die "pseudo" Charger FritzDect und Tasmato die ChargedEnergy Funktion auf Basis des in den Steckdosen mitgeschnittenen täglichen Energieverbrauchs ein.
Damit wären dann alle evcc "pseudo" Charger Feature-mäßig in sync.