Allow extra command line arguments #297 #298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--extra-args <extra-args>... Extra arguments; ignored, but show up in std::env::args()
I am, by hypothesis, a Rust newbie, so review may be in order.
Testing
EVCXR_TMPDIR=$HOME/tmp/e1 cargo test -- --test-threads 1
passed on MacOS 12.6.2 21G320 on M1 Max, with the same two crash dialogs I got from main.target/debug/evcxr --opt 2 --edit-mode emacs --extra-args \\--foo bar baz
gave:>> std::env::args()
Args { inner: ["/Users/flash/Documents/Code/external_code/evcxr/target/debug/evcxr", "target/debug/evcxr", "--opt", "2", "--edit-mode", "emacs", "--extra-args", "\\--foo", "bar", "baz"] }